netdev - Re: [PATCH iproute2 net-next v4 5/6] tc: etf: Add documentation for skip-skb-check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9198D117-BE06-468A-A908-24A162EDED0A@intel.com>
Date:   Thu, 18 Jul 2019 19:46:15 +0000
From:   "Patel, Vedang" <vedang.patel@...el.com>
To:     David Ahern <dsahern@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "Dorileo, Leandro" <leandro.maciel.dorileo@...el.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "m-karicheri2@...com" <m-karicheri2@...com>
Subject: Re: [PATCH iproute2 net-next v4 5/6] tc: etf: Add documentation for
 skip-skb-check.



> On Jul 18, 2019, at 10:36 AM, David Ahern <dsahern@...il.com> wrote:
> 
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> Document the newly added option (skip-skb-check) on the etf man-page.
>> 
>> Signed-off-by: Vedang Patel <vedang.patel@...el.com>
>> ---
>> man/man8/tc-etf.8 | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>> 
>> diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
>> index 30a12de7d2c7..2e01a591dbaa 100644
>> --- a/man/man8/tc-etf.8
>> +++ b/man/man8/tc-etf.8
>> @@ -106,6 +106,16 @@ referred to as "Launch Time" or "Time-Based Scheduling" by the
>> documentation of network interface controllers.
>> The default is for this option to be disabled.
>> 
>> +.TP
>> +skip_skb_check
> 
> patch 1 adds skip_sock_check.
> 
Yes. I will fix this typo in the next version.

Thanks,
Vedang
>> +.br
>> +.BR etf(8)
>> +currently drops any packet which does not have a socket associated with it or
>> +if the socket does not have SO_TXTIME socket option set. But, this will not
>> +work if the launchtime is set by another entity inside the kernel (e.g. some
>> +other Qdisc). Setting the skip_skb_check will skip checking for a socket
>> +associated with the packet.
>> +
>> .SH EXAMPLES
>> 
>> ETF is used to enforce a Quality of Service. It controls when each