netdev - Re: [PATCH] gve: replace kfree with kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190718.163207.289099133864098969.davem@davemloft.net>
Date:   Thu, 18 Jul 2019 16:32:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     chuhongyuan@...look.com
Cc:     csully@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gve: replace kfree with kvfree

From: Chuhong YUAN <chuhongyuan@...look.com>
Date: Wed, 17 Jul 2019 00:59:02 +0000

> Variables allocated by kvzalloc should not be freed by kfree.
> Because they may be allocated by vmalloc.
> So we replace kfree with kvfree here.
> 
> Signed-off-by: Chuhong Yuan <chuhongyuan@...look.com>

Applied, thanks Chuhong.

GVE maintainers, you are upstream now and have to stay on top of review
of changes like this.  Otherwise I'll just review it myself and apply
it unless I find problems, and that may not be what you want :)