netdev - Re: [patch net-next rfc 2/7] net: introduce name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jul 2019 09:29:36 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        jakub.kicinski@...ronome.com, sthemmin@...rosoft.com,
        dsahern@...il.com, dcbw@...hat.com, mkubecek@...e.cz,
        andrew@...n.ch, parav@...lanox.com, saeedm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next rfc 2/7] net: introduce name_node struct to be
 used in hashlist

On Fri, 19 Jul 2019 13:00:24 +0200
Jiri Pirko <jiri@...nulli.us> wrote:

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  include/linux/netdevice.h | 10 +++-
>  net/core/dev.c            | 96 +++++++++++++++++++++++++++++++--------
>  2 files changed, 86 insertions(+), 20 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 88292953aa6f..74f99f127b0e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -918,6 +918,12 @@ struct dev_ifalias {
>  struct devlink;
>  struct tlsdev_ops;
>  
> +struct netdev_name_node {
> +	struct hlist_node hlist;
> +	struct net_device *dev;
> +	char *name

You probably can make this const char *

Do you want to add __rcu to this list?