netdev - Re: [PATCH iproute2 net-next v5 1/5] etf: Add skip_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C21E09F7-D035-46A5-A924-95AF9FB07D97@intel.com>
Date:   Fri, 19 Jul 2019 21:39:33 +0000
From:   "Patel, Vedang" <vedang.patel@...el.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "Dorileo, Leandro" <leandro.maciel.dorileo@...el.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "m-karicheri2@...com" <m-karicheri2@...com>,
        "dsahern@...il.com" <dsahern@...il.com>
Subject: Re: [PATCH iproute2 net-next v5 1/5] etf: Add skip_sock_check



> On Jul 18, 2019, at 10:12 PM, Stephen Hemminger <stephen@...workplumber.org> wrote:
> 
> On Thu, 18 Jul 2019 12:55:39 -0700
> Vedang Patel <vedang.patel@...el.com> wrote:
> 
>> -	print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
>> +	print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
>> 				(qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on" : "off");
>> +	print_string(PRINT_ANY, "skip_sock_check", "skip_sock_check %s",
>> +				(qopt->flags & TC_ETF_SKIP_SOCK_CHECK) ? "on" : "off");
> 
> These should really be boolean options in JSON, not string values.
Ok. Sending out a patch to fix this.

Thanks,
Vedang