netdev - Re: [PATCH v2] ag71xx: fix return value check in ag71xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190718.203447.802057574398577206.davem@davemloft.net>
Date:   Thu, 18 Jul 2019 20:34:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     jcliburn@...il.com, chris.snook@...il.com, o.rempel@...gutronix.de,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] ag71xx: fix return value check in ag71xx_probe()

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Fri, 19 Jul 2019 01:22:06 +0000

> In case of error, the function of_get_mac_address() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

Applied.