netdev - Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <43FB794B-6200-4560-BF10-BBF4B9247913@linux.ibm.com>
Date:   Fri, 19 Jul 2019 15:12:24 +0200
From:   Ilya Leoshkevich <iii@...ux.ibm.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, lmb@...udflare.com,
        gor@...ux.ibm.com, heiko.carstens@...ibm.com
Subject: Re: [PATCH bpf] tools/bpf: fix bpftool build with OUTPUT set

> Am 18.07.2019 um 20:51 schrieb Jakub Kicinski <jakub.kicinski@...ronome.com>:
> 
> We should probably make a script with all the ways of calling make
> should work. Otherwise we can lose track too easily.

Thanks for the script!

I’m trying to make it all pass now, and hitting a weird issue in the
Kbuild case. The build prints "No rule to make target
'scripts/Makefile.ubsan.o'" and proceeds with an empty BPFTOOL_VERSION,
which causes problems later on.

I've found that this is caused by sub_make_done=1 environment variable,
and unsetting it indeed fixes the problem, since the root Makefile no
longer uses the implicit %.o rule.

However, I wonder if that would be acceptable in the final version of
the patch, and whether there is a cleaner way to achieve the same
effect?

Best regards,
Ilya