lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Jul 2019 20:50:23 +0200 From: Arnd Bergmann <arnd@...db.de> To: Florian Weimer <fw@...eb.enyo.de> Cc: Sergei Trofimovich <slyfox@...too.org>, Networking <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, GNU C Library <libc-alpha@...rceware.org>, "David S. Miller" <davem@...emloft.net>, Michael Kerrisk <mtk.manpages@...il.com>, linux-man <linux-man@...r.kernel.org> Subject: Re: linux-headers-5.2 and proper use of SIOCGSTAMP On Sat, Jul 20, 2019 at 8:10 PM Florian Weimer <fw@...eb.enyo.de> wrote: > > * Sergei Trofimovich: > > > Should #include <linux/sockios.h> always be included by user app? > > Or should glibc tweak it's definition of '#include <sys/socket.h>' > > to make it available on both old and new version of linux headers? > > What is the reason for dropping SIOCGSTAMP from <asm/socket.h>? > > If we know that, it will be much easier to decide what to do about > <sys/socket.h>. As far as I can tell, nobody thought it would be a problem to move it from asm/sockios.h to linux/sockios.h, as the general rule is that one should use the linux/*.h version if both exist, and that the asm/*.h version only contains architecture specific definitions. The new definition is the same across all architectures, so it made sense to have it in the common file. If the assumption was wrong, the obvious solution is to duplicate the definitions everywhere or move the common parts into asm-generic/sockios.h, but it would have been better to hear about that earlier. Arnd
Powered by blists - more mailing lists