lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 21 Jul 2019 02:26:23 +0200
From:   Florian Westphal <>
To:     Wenwen Wang <>
Cc:     Wenwen Wang <>,
        Pablo Neira Ayuso <>,
        Jozsef Kadlecsik <>,
        Florian Westphal <>,
        Roopa Prabhu <>,
        Nikolay Aleksandrov <>,
        "David S. Miller" <>,
        "open list:NETFILTER" <>,
        "open list:NETFILTER" <>,
        "moderated list:ETHERNET BRIDGE" <>,
        "open list:ETHERNET BRIDGE" <>,
        open list <>
Subject: Re: [PATCH] netfilter: ebtables: compat: fix a memory leak bug

Wenwen Wang <> wrote:
> From: Wenwen Wang <>
> In compat_do_replace(), a temporary buffer is allocated through vmalloc()
> to hold entries copied from the user space. The buffer address is firstly
> saved to 'newinfo->entries', and later on assigned to 'entries_tmp'. Then
> the entries in this temporary buffer is copied to the internal kernel
> structure through compat_copy_entries(). If this copy process fails,
> compat_do_replace() should be terminated. However, the allocated temporary
> buffer is not freed on this path, leading to a memory leak.
> To fix the bug, free the buffer before returning from compat_do_replace().
> Signed-off-by: Wenwen Wang <>

Reviewed-by: Florian Westphal <>

Powered by blists - more mailing lists