netdev - Re: [PATCH net] net: phy: sfp: hwmon: Fix scaling of RX power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Jul 2019 11:52:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, rmk+kernel@....linux.org.uk,
        Chris.Healy@....aero
Subject: Re: [PATCH net] net: phy: sfp: hwmon: Fix scaling of RX power

From: Andrew Lunn <andrew@...n.ch>
Date: Sun, 21 Jul 2019 18:50:08 +0200

> The RX power read from the SFP uses units of 0.1uW. This must be
> scaled to units of uW for HWMON. This requires a divide by 10, not the
> current 100.
> 
> With this change in place, sensors(1) and ethtool -m agree:
> 
> sff2-isa-0000
> Adapter: ISA adapter
> in0:          +3.23 V
> temp1:        +33.1 C
> power1:      270.00 uW
> power2:      200.00 uW
> curr1:        +0.01 A
> 
>         Laser output power                        : 0.2743 mW / -5.62 dBm
>         Receiver signal average optical power     : 0.2014 mW / -6.96 dBm
> 
> Reported-by: chris.healy@....aero
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> Fixes: 1323061a018a ("net: phy: sfp: Add HWMON support for module sensors")

Applied and queued up for -stable, thanks Andrew.