netdev - Re: [PATCH net] be2net: Synchronize be_update_queues with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Jul 2019 13:22:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bpoirier@...e.com
Cc:     sathya.perla@...adcom.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        fyang@...e.com, saeedm@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] be2net: Synchronize be_update_queues with
 dev_watchdog

From: Benjamin Poirier <bpoirier@...e.com>
Date: Thu, 18 Jul 2019 10:42:18 +0900

> As pointed out by Firo Yang, a netdev tx timeout may trigger just before an
> ethtool set_channels operation is started. be_tx_timeout(), which dumps
> some queue structures, is not written to run concurrently with
> be_update_queues(), which frees/allocates those queues structures. Add some
> synchronization between the two.
> 
> Message-id: <CH2PR18MB31898E033896F9760D36BFF288C90@...PR18MB3189.namprd18.prod.outlook.com>
> Signed-off-by: Benjamin Poirier <bpoirier@...e.com>

Applied and queued up for -stable, thanks.