netdev - Re: [PATCH bpf] selftests/bpf: fix sendmsg6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38573bb9-5e3a-73f4-5475-a7b2e24758cb@iogearbox.net>
Date:   Mon, 22 Jul 2019 16:23:49 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Ilya Leoshkevich <iii@...ux.ibm.com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     gor@...ux.ibm.com, heiko.carstens@...ibm.com, rdna@...com
Subject: Re: [PATCH bpf] selftests/bpf: fix sendmsg6_prog on s390

On 7/19/19 11:06 AM, Ilya Leoshkevich wrote:
> "sendmsg6: rewrite IP & port (C)" fails on s390, because the code in
> sendmsg_v6_prog() assumes that (ctx->user_ip6[0] & 0xFFFF) refers to
> leading IPv6 address digits, which is not the case on big-endian
> machines.
> 
> Since checking bitwise operations doesn't seem to be the point of the
> test, replace two short comparisons with a single int comparison.
> 
> Signed-off-by: Ilya Leoshkevich <iii@...ux.ibm.com>

Applied, thanks!