netdev - Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190723.142448.414859031558093111.davem@davemloft.net>
Date:   Tue, 23 Jul 2019 14:24:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     snelson@...sando.io
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells

From: Shannon Nelson <snelson@...sando.io>
Date: Mon, 22 Jul 2019 14:40:09 -0700

> The ionic interrupt model is based on interrupt control blocks
> accessed through the PCI BAR.  Doorbell registers are used by
> the driver to signal to the NIC that requests are waiting on
> the message queues.  Interrupts are used by the NIC to signal
> to the driver that answers are waiting on the completion queues.
> 
> Signed-off-by: Shannon Nelson <snelson@...sando.io>

After applying this patch we get a warning:

drivers/net/ethernet/pensando/ionic/ionic_lif.c:33:13: warning: ‘ionic_intr_free’ defined but not used [-Wunused-function]
 static void ionic_intr_free(struct lif *lif, int index)
             ^~~~~~~~~~~~~~~
drivers/net/ethernet/pensando/ionic/ionic_lif.c:15:12: warning: ‘ionic_intr_alloc’ defined but not used [-Wunused-function]
 static int ionic_intr_alloc(struct lif *lif, struct intr *intr)
            ^~~~~~~~~~~~~~~~

Also:

> +	lif->dbid_inuse = kzalloc(BITS_TO_LONGS(lif->dbid_count) * sizeof(long),
> +				  GFP_KERNEL);

You can use bitmap_alloc() and friends from linux/bitmap.h for this kind of stuff.