netdev - Re: [PATCH v2] net: dsa: qca8k: enable port flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201907250152.6Zq1v9Hm%lkp@intel.com>
Date:   Thu, 25 Jul 2019 01:05:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     xiaofeis <xiaofeis@...eaurora.org>
Cc:     kbuild-all@...org, davem@...emloft.net, vkoul@...nel.org,
        netdev@...r.kernel.org, andrew@...n.ch,
        linux-arm-msm@...r.kernel.org, bjorn.andersson@...aro.org,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        niklas.cassel@...aro.org, xiazha@...eaurora.org,
        xiaofeis <xiaofeis@...eaurora.org>
Subject: Re: [PATCH v2] net: dsa: qca8k: enable port flow control

Hi xiaofeis,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.3-rc1 next-20190724]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/xiaofeis/net-dsa-qca8k-enable-port-flow-control/20190724-221126
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net//dsa/qca8k.c: In function 'qca8k_port_enable':
>> drivers/net//dsa/qca8k.c:938:19: error: assignment to expression with array type
     phy->advertising |= ADVERTISED_Pause | ADVERTISED_Asym_Pause;
                      ^~

vim +938 drivers/net//dsa/qca8k.c

   928	
   929	static int
   930	qca8k_port_enable(struct dsa_switch *ds, int port,
   931			  struct phy_device *phy)
   932	{
   933		struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv;
   934	
   935		qca8k_port_set_status(priv, port, 1);
   936		priv->port_sts[port].enabled = 1;
   937	
 > 938		phy->advertising |= ADVERTISED_Pause | ADVERTISED_Asym_Pause;
   939	
   940		return 0;
   941	}
   942	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (71365 bytes)