netdev - Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Jul 2019 11:46:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     willy@...radead.org
Cc:     David.Laight@...lab.com, hch@....de, netdev@...r.kernel.org
Subject: Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

From: Matthew Wilcox <willy@...radead.org>
Date: Wed, 24 Jul 2019 04:41:21 -0700

> On Wed, Jul 24, 2019 at 10:49:03AM +0000, David Laight wrote:
>> This is 'just plain stupid'.
>> The 'bv_' prefix of the members of 'struct bvec' is there so that 'grep'
>> (etc) can be used to find the uses of the members.
>> 
>> In a 'struct skb_frag_struct' a sensible prefix might be 'sf_'.
>> 
>> OTOH it might be sensible to use (or embed) a 'struct bvec'
>> instead of 'skb_frag_struct'.
> 
> Maybe you should read patch 7/7.  Or 0/7.

+1