netdev - Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbc85d6d-b0cd-43d4-aded-88b482ecc477@pensando.io>
Date:   Tue, 23 Jul 2019 17:07:42 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo
 support

On 7/23/19 4:20 PM, Saeed Mahameed wrote:
> On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote:
>>

>> @@ -607,6 +947,8 @@ static void ionic_lif_free(struct lif *lif)
>>   	ionic_qcqs_free(lif);
>>   	ionic_lif_reset(lif);
>>   
> I don't think you want deferred.work running while reset is executing..
> cancel_work_sync should happen as early as you close the netdevice.

Given the current implementation, it doesn't actually hurt anything, but 
yes it makes sense to move it up in the sequence.

> I assume ionic_lif_reset will flush all configurations and you don't
> need to cleanup anything manually?  or any data structure stored in
> driver ?

Most of the driver data structure cleaning has happened in 
ionic_lif_deinit() before getting here.

sln