netdev - Re: [PATCH RFC net-next] net: use helper skb_ensure_writable in skb_checksum_help and skb_crc32c_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190724.154350.1802484068909792335.davem@davemloft.net>
Date:   Wed, 24 Jul 2019 15:43:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH RFC net-next] net: use helper skb_ensure_writable in
 skb_checksum_help and skb_crc32c_csum_help

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 24 Jul 2019 23:47:49 +0200

> Instead of open-coding making the checksum writable we can use an
> appropriate helper. skb_ensure_writable is a candidate, however we
> might also use skb_header_unclone. Hints welcome.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

FWIW these conversions look accurate to me.

The only real difference is the perhaps unnecessary pskb_may_pull()
check.