lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Jul 2019 21:45:36 -0700 From: john.hubbard@...il.com To: Andrew Morton <akpm@...ux-foundation.org> Cc: Alexander Viro <viro@...iv.linux.org.uk>, Björn Töpel <bjorn.topel@...el.com>, Boaz Harrosh <boaz@...xistor.com>, Christoph Hellwig <hch@....de>, Daniel Vetter <daniel@...ll.ch>, Dan Williams <dan.j.williams@...el.com>, Dave Chinner <david@...morbit.com>, David Airlie <airlied@...ux.ie>, "David S . Miller" <davem@...emloft.net>, Ilya Dryomov <idryomov@...il.com>, Jan Kara <jack@...e.cz>, Jason Gunthorpe <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>, Jérôme Glisse <jglisse@...hat.com>, Johannes Thumshirn <jthumshirn@...e.de>, Magnus Karlsson <magnus.karlsson@...el.com>, Matthew Wilcox <willy@...radead.org>, Miklos Szeredi <miklos@...redi.hu>, Ming Lei <ming.lei@...hat.com>, Sage Weil <sage@...hat.com>, Santosh Shilimkar <santosh.shilimkar@...cle.com>, Yan Zheng <zyan@...hat.com>, netdev@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-mm@...ck.org, linux-rdma@...r.kernel.org, bpf@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, John Hubbard <jhubbard@...dia.com> Subject: [PATCH v3 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*() From: John Hubbard <jhubbard@...dia.com> For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Also reverse the order of a comparison, in order to placate checkpatch.pl. Cc: David Airlie <airlied@...ux.ie> Cc: Daniel Vetter <daniel@...ll.ch> Cc: dri-devel@...ts.freedesktop.org Signed-off-by: John Hubbard <jhubbard@...dia.com> --- drivers/gpu/drm/via/via_dmablit.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c index 062067438f1d..b5b5bf0ba65e 100644 --- a/drivers/gpu/drm/via/via_dmablit.c +++ b/drivers/gpu/drm/via/via_dmablit.c @@ -171,7 +171,6 @@ via_map_blit_for_device(struct pci_dev *pdev, static void via_free_sg_info(struct pci_dev *pdev, drm_via_sg_info_t *vsg) { - struct page *page; int i; switch (vsg->state) { @@ -186,13 +185,8 @@ via_free_sg_info(struct pci_dev *pdev, drm_via_sg_info_t *vsg) kfree(vsg->desc_pages); /* fall through */ case dr_via_pages_locked: - for (i = 0; i < vsg->num_pages; ++i) { - if (NULL != (page = vsg->pages[i])) { - if (!PageReserved(page) && (DMA_FROM_DEVICE == vsg->direction)) - SetPageDirty(page); - put_page(page); - } - } + put_user_pages_dirty_lock(vsg->pages, vsg->num_pages, + (vsg->direction == DMA_FROM_DEVICE)); /* fall through */ case dr_via_pages_alloc: vfree(vsg->pages); -- 2.22.0
Powered by blists - more mailing lists