netdev - Re: [PATCH 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b74e0c3-cdfc-1bf6-e565-e677a01a2244@denx.de>
Date:   Thu, 25 Jul 2019 17:36:14 +0200
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, Tristram Ha <Tristram.Ha@...rochip.com>,
        "David S . Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [PATCH 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

On 7/25/19 4:59 PM, Andrew Lunn wrote:
> On Thu, Jul 25, 2019 at 04:56:37PM +0200, Marek Vasut wrote:
>> On 7/25/19 4:03 PM, Andrew Lunn wrote:
>>> On Wed, Jul 24, 2019 at 03:40:48PM +0200, Marek Vasut wrote:
>>>> From: Tristram Ha <Tristram.Ha@...rochip.com>
>>>> +static void ksz8795_phy_setup(struct ksz_device *dev, int port,
>>>> +			      struct phy_device *phy)
>>>> +{
>>>> +	if (port < dev->phy_port_cnt) {
>>>> +		/*
>>>> +		 * SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to
>>>> +		 * disable flow control when rate limiting is used.
>>>> +		 */
>>>> +		linkmode_copy(phy->advertising, phy->supported);
>>>> +	}
>>>> +}
>>>
>>> Hi Marek
>>>
>>> Do you know why this is needed?
>>
>> Unfortunately, no.
>>
>> It seems it copies supported features of the PHY to advertised features
>> of the PHY for ports which are downstream (i.e. not the CPU port).
> 
> Hi Marek
> 
> Could you test it without this copy? Do you get sensible values from
> ethtool? Does the pause configuration look sensible?

They do look OK even without the code.