netdev - Re: [PATCH] net-next: ag71xx: Rearrange ag711xx struct to remove holes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190725.112108.2287417619951369896.davem@davemloft.net>
Date:   Thu, 25 Jul 2019 11:21:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rosenp@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net-next: ag71xx: Rearrange ag711xx struct to remove
 holes

From: Rosen Penev <rosenp@...il.com>
Date: Mon, 22 Jul 2019 20:43:09 -0700

> Removed ____cacheline_aligned attribute to ring structs. This actually
> causes holes in the ag71xx struc as well as lower performance.

If you are legitimizing a change because of performance you must provide
detailed performance results that support this reason.

I'm not applying this patch until you respin it with the required
information.

Thank you.