netdev - Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190725192704.GB1440@kunai>
Date:   Thu, 25 Jul 2019 21:27:04 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Edward Cree <ecree@...arflare.com>
Cc:     David Miller <davem@...emloft.net>,
        wsa+renesas@...g-engineering.com, linux-i2c@...r.kernel.org,
        linux-net-drivers@...arflare.com, mhabets@...arflare.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device


> >> Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an
> >> ERRPTR which we use in error handling.
> >>
> >> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> 
> Subject & description are incomplete, you're also changing i2c_new_device()
>  to i2c_new_client_device().

Right, this was an anomaly with this patch to have both code paths
returning an ERRPTR. The big conversion for i2c_new_device will come
later in a seperate series.

> Other than that,
> Acked-by: Edward Cree <ecree@...arflare.com>

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)