netdev - Re: [PATCH v2 2/2] mwifiex: Make use of the new sdio_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87imrqzmgc.fsf@kamboji.qca.qualcomm.com>
Date:   Thu, 25 Jul 2019 08:56:35 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ganapathi Bhat <gbhat@...vell.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Andreas Fenkart <afenkart@...il.com>,
        Brian Norris <briannorris@...omium.org>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        "open list\:ARM\/Rockchip SoC..." 
        <linux-rockchip@...ts.infradead.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        netdev <netdev@...r.kernel.org>,
        Avri Altman <avri.altman@....com>,
        Linux MMC List <linux-mmc@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Xinming Hu <huxinming820@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] mwifiex: Make use of the new sdio_trigger_replug() API to reset

Doug Anderson <dianders@...omium.org> writes:

> Hi,
>
> On Wed, Jul 24, 2019 at 4:35 AM Kalle Valo <kvalo@...eaurora.org> wrote:
>>
>> Douglas Anderson <dianders@...omium.org> wrote:
>>
>> > As described in the patch ("mmc: core: Add sdio_trigger_replug()
>> > API"), the current mwifiex_sdio_card_reset() is broken in the cases
>> > where we're running Bluetooth on a second SDIO func on the same card
>> > as WiFi.  The problem goes away if we just use the
>> > sdio_trigger_replug() API call.
>> >
>> > NOTE: Even though with this new solution there is less of a reason to
>> > do our work from a workqueue (the unplug / plug mechanism we're using
>> > is possible for a human to perform at any time so the stack is
>> > supposed to handle it without it needing to be called from a special
>> > context), we still need a workqueue because the Marvell reset function
>> > could called from a context where sleeping is invalid and thus we
>> > can't claim the host.  One example is Marvell's wakeup_timer_fn().
>> >
>> > Cc: Andreas Fenkart <afenkart@...il.com>
>> > Cc: Brian Norris <briannorris@...omium.org>
>> > Fixes: b4336a282db8 ("mwifiex: sdio: reset adapter using mmc_hw_reset")
>> > Signed-off-by: Douglas Anderson <dianders@...omium.org>
>> > Reviewed-by: Brian Norris <briannorris@...omium.org>
>>
>> I assume this is going via some other tree so I'm dropping this from my
>> queue. If I should apply this please resend once the dependency is in
>> wireless-drivers-next.
>>
>> Patch set to Not Applicable.
>
> Thanks.  For now I'll assume that Ulf will pick it up if/when he is
> happy with patch #1 in this series.  Would you be willing to provide
> your Ack on this patch to make it clear to Ulf you're OK with that?

Sure, I was planning to do that already in my previous email but forgot.

Acked-by: Kalle Valo <kvalo@...eaurora.org>

-- 
Kalle Valo