netdev - Re: [PATCH] qlge: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190725111414.GB30958@kroah.com>
Date:   Thu, 25 Jul 2019 13:14:14 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     David Miller <davem@...emloft.net>
Cc:     yuehaibing@...wei.com, bpoirier@...e.com,
        devel@...verdev.osuosl.org, GR-Linux-NIC-Dev@...vell.com,
        manishc@...vell.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET

On Wed, Jul 24, 2019 at 02:12:28PM -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT)
> 
> > From: YueHaibing <yuehaibing@...wei.com>
> > Date: Wed, 24 Jul 2019 21:01:26 +0800
> > 
> >> Now if CONFIG_ETHERNET is not set, QLGE driver
> >> building fails:
> >> 
> >> drivers/staging/qlge/qlge_main.o: In function `qlge_remove':
> >> drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev'
> >> 
> >> Reported-by: Hulk Robot <hulkci@...wei.com>
> >> Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/")
> >> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > 
> > I'll let Greg take this.
> 
> Actually, I take that back.
> 
> Since the move to staging happened in my tree I will take this ;-)

Thanks.  If you want to push that "move" to Linus soon, I can then take
any cleanup patches that show up for this driver, otherwise feel free to
ignore them until 5.4-rc1.

thanks,

greg k-h