netdev - Re: [PATCH v2] net: dsa: qca8k: enable port flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190726132919.GB18223@lunn.ch>
Date:   Fri, 26 Jul 2019 15:29:19 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     xiaofeis@...eaurora.org
Cc:     vkoul@...nel.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] net: dsa: qca8k: enable port flow control

> I didn't compile it on this tree, same code is just compiled and tested on
> kernel v4.14.

For kernel development work, v4.14 is dead. It died 12th November
2017. It gets backports of bug fixes, but kernel developers otherwise
don't touch it.

> We are working on one google project, all the change is
> required to upstream by Google.
> But if I do the change based on the new type for kernel 5.3, then the commit
> can't be used directly for Google's project.

So you will need to backport the change. In this case, you will have a
very different patch in v4.14 than in mainline, due to changes like
this. That is part of the pain in using such an old kernel.

You should use the function 

void phy_support_asym_pause(struct phy_device *phydev);

to indicate the MAC supports asym pause.

   Andrew