netdev - Re: [PATCH] iproute2: devlink: use sys/queue.h from libbsd as a fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190726112956.3b54f906@hermes.lan>
Date:   Fri, 26 Jul 2019 11:29:56 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Sergei Trofimovich <slyfox@...too.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] iproute2: devlink: use sys/queue.h from libbsd as a
 fallback

On Wed, 24 Jul 2019 09:18:38 +0100
Sergei Trofimovich <slyfox@...too.org> wrote:

> On sys/queue.h does not exist linux-musl targets and
> fails build as:
> 
>     devlink.c:28:10: fatal error: sys/queue.h: No such file or directory
>        28 | #include <sys/queue.h>
>           |          ^~~~~~~~~~~~~
> 
> The change pulls in 'sys/queue.h' from libbsd in case
> system headers don't already provides it.
> 
> Tested on linux-musl and linux-glibc.
> 
> Bug: https://bugs.gentoo.org/690486
> CC: Stephen Hemminger <stephen@...workplumber.org>
> CC: netdev@...r.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@...too.org>
> ---

This is ugly and causes more maintainability issues.

Maybe just fix devlink not to depend on sys/queue.h at all.
It makes more sense to have common code style and usage across all of
iproute2.

We already have local version list.h, why continue with BSD stuff.