lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Jul 2019 17:49:37 -0300 From: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com> To: Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andriin@...com> Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...com, daniel@...earbox.net, acme@...hat.com, andrii.nakryiko@...il.com, kernel-team@...com Subject: Re: [PATCH v2 bpf] libbpf: fix missing __WORDSIZE definition Em Thu, Jul 18, 2019 at 10:30:21AM -0700, Andrii Nakryiko escreveu: > hashmap.h depends on __WORDSIZE being defined. It is defined by > glibc/musl in different headers. It's an explicit goal for musl to be > "non-detectable" at compilation time, so instead include glibc header if > glibc is explicitly detected and fall back to musl header otherwise. > > Fixes: e3b924224028 ("libbpf: add resizable non-thread safe internal hashmap") > Reported-by: Arnaldo Carvalho de Melo <acme@...hat.com> > Signed-off-by: Andrii Nakryiko <andriin@...com> Couldn't find ths in the bpf tree, please consider applying it: Tested-by: Arnaldo Carvalho de Melo <acme@...hat.com> - Arnaldo > --- > tools/lib/bpf/hashmap.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/lib/bpf/hashmap.h b/tools/lib/bpf/hashmap.h > index 03748a742146..bae8879cdf58 100644 > --- a/tools/lib/bpf/hashmap.h > +++ b/tools/lib/bpf/hashmap.h > @@ -10,6 +10,11 @@ > > #include <stdbool.h> > #include <stddef.h> > +#ifdef __GLIBC__ > +#include <bits/wordsize.h> > +#else > +#include <bits/reg.h> > +#endif > #include "libbpf_internal.h" > > static inline size_t hash_bits(size_t h, int bits) > -- > 2.17.1 -- - Arnaldo
Powered by blists - more mailing lists