netdev - Re: [PATCH v2] iproute2: devlink: port from sys/queue.h to list.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190726150249.5f1e6167@hermes.lan>
Date:   Fri, 26 Jul 2019 15:02:49 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Sergei Trofimovich <slyfox@...too.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] iproute2: devlink: port from sys/queue.h to list.h

On Fri, 26 Jul 2019 22:01:05 +0100
Sergei Trofimovich <slyfox@...too.org> wrote:

> sys/queue.h does not exist on linux-musl targets and fails build as:
> 
>     devlink.c:28:10: fatal error: sys/queue.h: No such file or directory
>        28 | #include <sys/queue.h>
>           |          ^~~~~~~~~~~~~
> 
> The change ports to list.h API and drops dependency of 'sys/queue.h'.
> The API maps one-to-one.
> 
> Build-tested on linux-musl and linux-glibc.
> 
> Bug: https://bugs.gentoo.org/690486
> CC: Stephen Hemminger <stephen@...workplumber.org>
> CC: netdev@...r.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@...too.org>

Looks good, thanks for following through.
Applied.