netdev - Re: [PATCH] b43legacy: Remove pointless cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46a1581f-6fd7-92b4-4eec-8196254e63cc@lwfinger.net>
Date:   Fri, 26 Jul 2019 20:52:09 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Thomas Gleixner <tglx@...utronix.de>, netdev@...r.kernel.org
Cc:     b43-dev@...ts.infradead.org, Kalle Valo <kvalo@...eaurora.org>
Subject: Re: [PATCH] b43legacy: Remove pointless cond_resched() wrapper

On 7/26/19 3:00 PM, Thomas Gleixner wrote:
> cond_resched() can be used unconditionally. If CONFIG_PREEMPT is set, it
> becomes a NOP scheduler wise.
> 
> Also the B43_BUG_ON() in that wrapper is a homebrewn variant of
> __might_sleep() which is part of cond_resched() already.
> 
> Remove the wrapper and invoke cond_resched() directly.
> 
> Found while looking for CONFIG_PREEMPT dependent code treewide.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: netdev@...r.kernel.org
> Cc: b43-dev@...ts.infradead.org
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Larry Finger <Larry.Finger@...inger.net>

Reviewed- and Tested-by: Larry Finger <Larry.Finger@...inger.net>

Thanks.

Larry