netdev - Re: [PATCH 2/2] staging/octeon: Allow test build on !MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190727105706.GB458@kroah.com>
Date:   Sat, 27 Jul 2019 12:57:06 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, aaro.koskinen@....fi,
        arnd@...db.de
Subject: Re: [PATCH 2/2] staging/octeon: Allow test build on !MIPS

On Fri, Jul 26, 2019 at 10:44:25AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> 
> Add compile test support by moving all includes of files under
> asm/octeon into octeon-ethernet.h, and if we're not on MIPS,
> stub out all the calls into the octeon support code in octeon-stubs.h
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> ---
>  drivers/staging/octeon/Kconfig            |    2 +-
>  drivers/staging/octeon/ethernet-defines.h |    2 -
>  drivers/staging/octeon/ethernet-mdio.c    |    6 +-
>  drivers/staging/octeon/ethernet-mem.c     |    5 +-
>  drivers/staging/octeon/ethernet-rgmii.c   |   10 +-
>  drivers/staging/octeon/ethernet-rx.c      |   13 +-
>  drivers/staging/octeon/ethernet-rx.h      |    2 -
>  drivers/staging/octeon/ethernet-sgmii.c   |    8 +-
>  drivers/staging/octeon/ethernet-spi.c     |   10 +-
>  drivers/staging/octeon/ethernet-tx.c      |   12 +-
>  drivers/staging/octeon/ethernet-util.h    |    4 -
>  drivers/staging/octeon/ethernet.c         |   12 +-
>  drivers/staging/octeon/octeon-ethernet.h  |   29 +-
>  drivers/staging/octeon/octeon-stubs.h     | 1429 +++++++++++++++++++++
>  14 files changed, 1466 insertions(+), 78 deletions(-)
>  create mode 100644 drivers/staging/octeon/octeon-stubs.h

No real objection from me, having this driver able to be built on
non-mips systems would be great.

But wow, that stubs.h file is huge, you really need all of that?
There's no way to include the files from the mips "core" directly
instead for some of it?

If not, that's fine, and all of this can go through net-next:

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>