netdev - Re: [PATCH 2/2] staging/octeon: Allow test build on !MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190727145145.GA21910@kroah.com>
Date:   Sat, 27 Jul 2019 16:51:45 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, aaro.koskinen@....fi,
        arnd@...db.de
Subject: Re: [PATCH 2/2] staging/octeon: Allow test build on !MIPS

On Sat, Jul 27, 2019 at 07:28:26AM -0700, Matthew Wilcox wrote:
> On Sat, Jul 27, 2019 at 12:57:06PM +0200, Greg KH wrote:
> > No real objection from me, having this driver able to be built on
> > non-mips systems would be great.
> > 
> > But wow, that stubs.h file is huge, you really need all of that?
> > There's no way to include the files from the mips "core" directly
> > instead for some of it?
> 
> I don't know.  I went the route of copying each structure/enum wholesale
> as I came across it in the build log rather than taking only the pieces
> of it that I needed.  My time versus a few hundred lines of source?
> 
> I think that a more wholesale restructuring of this driver would be
> helpful; there are a number of structures that are only used in the
> driver and not in the arch code, and those could then be removed from
> the stubs file.  But I have no long term investment in this driver;
> it just annoyed me to not be able to build it.

Ok, again, no objection from me, thanks for doing this work.

greg k-h