netdev - Re: [PATCH] rocker: fix memory leaks of fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190728074619.GA2423@nanopsycho.orion>
Date:   Sun, 28 Jul 2019 09:46:19 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Colin King <colin.king@...onical.com>
Cc:     David Ahern <dsahern@...il.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rocker: fix memory leaks of fib_work on two error return
 paths

Sun, Jul 28, 2019 at 01:37:26AM CEST, colin.king@...onical.com wrote:
>From: Colin Ian King <colin.king@...onical.com>
>
>Currently there are two error return paths that leak memory allocated
>to fib_work. Fix this by kfree'ing fib_work before returning.
>
>Addresses-Coverity: ("Resource leak")
>Fixes: 19a9d136f198 ("ipv4: Flag fib_info with a fib_nh using IPv6 gateway")
>Fixes: dbcc4fa718ee ("rocker: Fail attempts to use routes with nexthop objects")
>Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>