netdev - RE: [PATCH net-next v3 2/4] enetc: Add mdio bus driver for the PCIe MDIO endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB488060D95CFD31CB904CDF6796DD0@VI1PR04MB4880.eurprd04.prod.outlook.com>
Date:   Mon, 29 Jul 2019 15:46:17 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Claudiu Manoil <claudiu.manoil@....com>,
        Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, Leo Li <leoyang.li@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v3 2/4] enetc: Add mdio bus driver for the PCIe
 MDIO endpoint

>-----Original Message-----
>From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
>Behalf Of Claudiu Manoil
>Sent: Monday, July 29, 2019 6:40 PM
>To: Andrew Lunn <andrew@...n.ch>
>Cc: David S . Miller <davem@...emloft.net>; Rob Herring
><robh+dt@...nel.org>; Leo Li <leoyang.li@....com>; Alexandru Marginean
><alexandru.marginean@....com>; netdev@...r.kernel.org;
>devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
>kernel@...r.kernel.org
>Subject: RE: [PATCH net-next v3 2/4] enetc: Add mdio bus driver for the PCIe
>MDIO endpoint
>
>>-----Original Message-----
>>From: Andrew Lunn <andrew@...n.ch>
>>Sent: Monday, July 29, 2019 6:35 PM
>>To: Claudiu Manoil <claudiu.manoil@....com>
>>Cc: David S . Miller <davem@...emloft.net>; Rob Herring
>><robh+dt@...nel.org>; Leo Li <leoyang.li@....com>; Alexandru Marginean
>><alexandru.marginean@....com>; netdev@...r.kernel.org;
>>devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
>>linux- kernel@...r.kernel.org
>>Subject: Re: [PATCH net-next v3 2/4] enetc: Add mdio bus driver for the
>>PCIe MDIO endpoint
>>
>>> +	hw->port = pci_iomap(pdev, 0, 0);
>>> +	if (!bus->priv) {
>>
>>hw->port ??
>>
>
>Yeah, better ignore this for now 😊
>It's for the enetc accessors, enetc_port_..().

Oh I see, it's a mistake.  I'm checking the wrong thing.
Sorry.  Thanks for the review.