netdev - Re: [PATCH] isdn: hfcsusb: Fix mISDN driver crash caused by transfer buffer on the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190729.094613.2239689143737241909.davem@davemloft.net>
Date:   Mon, 29 Jul 2019 09:46:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     juliana.rodrigueiro@...ra2net.com
Cc:     isdn@...ux-pingi.de, netdev@...r.kernel.org
Subject: Re: [PATCH] isdn: hfcsusb: Fix mISDN driver crash caused by
 transfer buffer on the stack

From: Juliana Rodrigueiro <juliana.rodrigueiro@...ra2net.com>
Date: Mon, 29 Jul 2019 10:20:56 +0200

> @@ -1705,12 +1705,22 @@ static int
>  setup_hfcsusb(struct hfcsusb *hw)
>  {
>  	u_char b;
> +	int ret;
> +	void *dmabuf = kmalloc(sizeof(u_char), GFP_KERNEL);

Please order these local variable declarations from longest to shortest line.

Thank you.