netdev - Re: [PATCH V3 2/3] net: dsa: ksz: Add KSZ8795 tag code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 10:33:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marex@...x.de
Cc:     netdev@...r.kernel.org, Tristram.Ha@...rochip.com, andrew@...n.ch,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        woojung.huh@...rochip.com
Subject: Re: [PATCH V3 2/3] net: dsa: ksz: Add KSZ8795 tag code

From: Marek Vasut <marex@...x.de>
Date: Fri, 26 Jul 2019 18:23:07 +0200

> @@ -77,6 +77,13 @@ config NET_DSA_TAG_KSZ_COMMON
>  	tristate
>  	default n
>  
> +config NET_DSA_TAG_KSZ8795
> +	tristate "Tag driver for Microchip 8795 family of switches"
> +	select NET_DSA_TAG_KSZ_COMMON
> +	help
> +	  Say Y if you want to enable support for tagging frames for the
> +	  Microchip 8795 family of switches.

This Kconfig knob doesn't control the inclusion of code at all.

It's only use is in patch #3 where it is selected for the new
NET_DSA_MICROCHIP_KSZ8795.

Therefore it isn't doing anything.

So please either make it control code inclusion or remove it.

Thank you.