netdev - Re: [PATCH V3 net-next 06/10] net: hns3: add debug messages to identify eth down cause

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df2dbffd-8493-025d-f861-9c5024559933@huawei.com>
Date:   Mon, 29 Jul 2019 09:21:41 +0800
From:   tanhuazhong <tanhuazhong@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <linuxarm@...wei.com>, <saeedm@...lanox.com>,
        <liuyonglong@...wei.com>, <lipeng321@...wei.com>
Subject: Re: [PATCH V3 net-next 06/10] net: hns3: add debug messages to
 identify eth down cause



On 2019/7/28 10:03, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@...wei.com>
> Date: Sat, 27 Jul 2019 13:46:08 +0800
> 
>> From: Yonglong Liu <liuyonglong@...wei.com>
>>
>> Some times just see the eth interface have been down/up via
>> dmesg, but can not know why the eth down. So adds some debug
>> messages to identify the cause for this.
>>
>> Signed-off-by: Yonglong Liu <liuyonglong@...wei.com>
>> Signed-off-by: Peng Li <lipeng321@...wei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3_enet.c       | 18 ++++++++++++++++++
>>   drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c    | 19 +++++++++++++++++++
>>   .../net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c    | 11 +++++++++++
>>   3 files changed, 48 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
>> index 4d58c53..973c57b 100644
>> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
>> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
>> @@ -459,6 +459,9 @@ static int hns3_nic_net_open(struct net_device *netdev)
>>   		h->ae_algo->ops->set_timer_task(priv->ae_handle, true);
>>   
>>   	hns3_config_xps(priv);
>> +
>> +	netif_info(h, drv, netdev, "net open\n");
> 
> These will pollute everyone's kernel logs for normal operations.
> 
> This is not reasonable at all, sorry.
> 
> Furthermore, even if it was appropriate, "netif_info()" is not "debug".
> 

Will replace it with netif_dbg.
thanks.

> 
> .
>