netdev - Re: [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 12:40:47 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     David Miller <davem@...emloft.net>
Cc:     clement.perrochaud@...innov.com, charles.gorand@...innov.com,
        netdev@...r.kernel.org, sedat.dilek@...dativ.de,
        sedat.dilek@...il.com
Subject: Re: [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt()

On Fri, Jul 26, 2019 at 02:23:46PM -0700, David Miller wrote:
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Date: Thu, 25 Jul 2019 22:35:08 +0300
> 
> > The macro had never been used.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Tested-by: Sedat Dilek <sedat.dilek@...il.com>
>  ...
> > @@ -12,8 +12,6 @@
> >   * Copyright (C) 2012  Intel Corporation. All rights reserved.
> >   */
> >  
> > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> If there are any kernel log messages generated, which is the case in
> this file, this is used.

AFAICS no, it's not.
All nfc_*() macros are built on top of dev_*() ones for which pr_fmt() is no-op.
If we would like to have it in that way, we rather should use dev_fmt().


> Also, please resubmit this series with a proper header posting containing
> a high level description of what this patch series does, how it is doing it,
> and why it is doing it that way.  Also include a changelog.

Will do.

Thank you for review!

-- 
With Best Regards,
Andy Shevchenko