netdev - Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d576168e-2893-d48e-3baa-b5e49f65e3b5@fb.com>
Date:   Tue, 30 Jul 2019 21:30:55 +0000
From:   Jens Axboe <axboe@...com>
To:     David Miller <davem@...emloft.net>
CC:     "jonathan.lemon@...il.com" <jonathan.lemon@...il.com>,
        "willy@...radead.org" <willy@...radead.org>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        Kernel Team <Kernel-team@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to
 bio_vec

On 7/30/19 3:22 PM, David Miller wrote:
> From: Jens Axboe <axboe@...com>
> Date: Tue, 30 Jul 2019 20:49:09 +0000
> 
>> Pretty appalled to see this abomination:
>>
>> net: Convert skb_frag_t to bio_vec
>>
>> There are a lot of users of frag->page_offset, so use a union
>> to avoid converting those users today.
>>
>> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
>> Signed-off-by: David S. Miller <davem@...emloft.net>
>>
>> show up in the net tree without even having been posted on a
>> block list...
>>
>> At least this kills this ugly thing.
> 
> Sorry about that Jens, but at least as you say it's gone now.

Yeah all good now, thanks.

-- 
Jens Axboe