netdev - Re: [PATCH net v2] ipvs: Improve robustness to the ipvs sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <484fef63-710a-701e-3151-eefaf3b9b1ca@huawei.com>
Date:   Wed, 31 Jul 2019 23:58:49 +0800
From:   hujunwei <hujunwei4@...wei.com>
To:     Julian Anastasov <ja@....bg>
CC:     <wensong@...ux-vs.org>, <horms@...ge.net.au>,
        <pablo@...filter.org>, <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>, <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        <lvs-devel@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
        <coreteam@...filter.org>, Mingfangsen <mingfangsen@...wei.com>,
        <wangxiaogang3@...wei.com>, <xuhanbing@...wei.com>
Subject: Re: [PATCH net v2] ipvs: Improve robustness to the ipvs sysctl

Hello, Julian

On 2019/7/31 3:29, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Tue, 30 Jul 2019, hujunwei wrote:
> 
>> From: Junwei Hu <hujunwei4@...wei.com>
>>
>> The ipvs module parse the user buffer and save it to sysctl,
>> then check if the value is valid. invalid value occurs
>> over a period of time.
>> Here, I add a variable, struct ctl_table tmp, used to read
>> the value from the user buffer, and save only when it is valid.
>> I delete proc_do_sync_mode and use extra1/2 in table for the
>> proc_dointvec_minmax call.
>>
>> Fixes: f73181c8288f ("ipvs: add support for sync threads")
>> Signed-off-by: Junwei Hu <hujunwei4@...wei.com>
> 
> 	Looks good to me, thanks!
> 
> Acked-by: Julian Anastasov <ja@....bg>
> 
> 	BTW, why ip_vs_zero_all everywhere? Due to old git version?
> 

I will update the git version and send the patch v3.

Regards,
Junwei