netdev - Re: [PATCH v2 net-next] be2net: disable bh with spin_lock in be_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 01 Aug 2019 12:55:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     kda@...ux-powerpc.org
Cc:     sathya.perla@...adcom.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] be2net: disable bh with spin_lock in
 be_process_mcc

From: Denis Kirjanov <kda@...ux-powerpc.org>
Date: Thu,  1 Aug 2019 11:24:20 +0200

> be_process_mcc() is invoked in 3 different places and
> always with BHs disabled except the be_poll function
> but since it's invoked from softirq with BHs
> disabled it won't hurt.
> 
> v1->v2: added explanation to the patch
> 
> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org>

Like Willem I see no benefit at all to this change.