netdev - Re: [PATCH net v2] mvpp2: fix panic on module removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190801.130847.1845352143685364558.davem@davemloft.net>
Date:   Thu, 01 Aug 2019 13:08:47 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mcroce@...hat.com
Cc:     netdev@...r.kernel.org, miquel.raynal@...e-electrons.com,
        linux-kernel@...r.kernel.org, lorenzo@...nel.org,
        antoine.tenart@...tlin.com, maxime.chevallier@...tlin.com,
        mw@...ihalf.com, stefanc@...vell.com
Subject: Re: [PATCH net v2] mvpp2: fix panic on module removal

From: Matteo Croce <mcroce@...hat.com>
Date: Thu,  1 Aug 2019 14:13:30 +0200

> mvpp2 uses a delayed workqueue to gather traffic statistics.
> On module removal the workqueue can be destroyed before calling
> cancel_delayed_work_sync() on its works.
> Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
> Also remove an unneeded call to flush_workqueue()
 ...
> Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics")
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> Signed-off-by: Matteo Croce <mcroce@...hat.com>

Applied and queued up for -stable, thanks.