netdev - Re: [RFC iproute2 0/4] Revert tc batchsize feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA93jw6aRwUt=r9EAeRmZmJJ=KbDTsdxyb8DQWCX4NWkOUsnbA@mail.gmail.com>
Date:   Wed, 31 Jul 2019 18:11:42 -0700
From:   Dave Taht <dave.taht@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Jiří Pírko <jiri@...nulli.us>,
        chrism@...lanox.com,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [RFC iproute2 0/4] Revert tc batchsize feature

Does this fix my longstanding issue with piping commands into it? :P

( https://github.com/tohojo/flent/issues/146 )

On Wed, Jul 31, 2019 at 5:46 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> The batchsize feature of tc might save a few cycles but it
> is a maintaince nightmare, it has uninitialized variables and
> poor error handling.
>
> This patch set reverts back to the original state.
> Please don't resubmit original code. Go back to the drawing
> board and do something generic.  For example, the routing
> daemons have figured out that by using multiple threads and
> turning off the netlink ACK they can update millions of routes
> quickly.
>
> Stephen Hemminger (4):
>   Revert "tc: Remove pointless assignments in batch()"
>   Revert "tc: flush after each command in batch mode"
>   Revert "tc: fix batch force option"
>   Revert "tc: Add batchsize feature for filter and actions"
>
>  tc/m_action.c  |  65 ++++++----------
>  tc/tc.c        | 201 ++++---------------------------------------------
>  tc/tc_common.h |   7 +-
>  tc/tc_filter.c | 129 ++++++++++++-------------------
>  4 files changed, 87 insertions(+), 315 deletions(-)
>


-- 

Dave Täht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-205-9740