netdev - RE: [PATCH][net-next] net/mlx5: remove self-assignment on esw->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Aug 2019 11:31:52 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Colin King <colin.king@...onical.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][net-next] net/mlx5: remove self-assignment on esw->dev



> -----Original Message-----
> From: linux-rdma-owner@...r.kernel.org <linux-rdma-
> owner@...r.kernel.org> On Behalf Of Colin King
> Sent: Friday, August 2, 2019 3:52 PM
> To: Saeed Mahameed <saeedm@...lanox.com>; Leon Romanovsky
> <leon@...nel.org>; David S . Miller <davem@...emloft.net>;
> netdev@...r.kernel.org; linux-rdma@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH][net-next] net/mlx5: remove self-assignment on esw->dev
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a self assignment of esw->dev to itself, clean this up by removing it.
> 
> Addresses-Coverity: ("Self assignment")
> Fixes: 6cedde451399 ("net/mlx5: E-Switch, Verify support QoS element type")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> index f4ace5f8e884..de0894b695e3 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> @@ -1413,7 +1413,7 @@ static int esw_vport_egress_config(struct
> mlx5_eswitch *esw,
> 
>  static bool element_type_supported(struct mlx5_eswitch *esw, int type)  {
Making it const struct mlx5_eswitch *esw brings improves code hygiene further in such functions.

> -	struct mlx5_core_dev *dev = esw->dev = esw->dev;
> +	struct mlx5_core_dev *dev = esw->dev;
> 
>  	switch (type) {
>  	case SCHEDULING_CONTEXT_ELEMENT_TYPE_TSAR:
> --
> 2.20.1