netdev - Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190802001900.uyuryet2lrr3hgsq@ast-mbp.dhcp.thefacebook.com>
Date:   Thu, 1 Aug 2019 17:19:02 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 00/15] net: Add functional tests for L3 and L4

On Thu, Aug 01, 2019 at 11:56:33AM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> This is a port the functional test cases created during the development
> of the VRF feature. It covers various permutations of icmp, tcp and udp
> for IPv4 and IPv6 including negative tests.

Thanks a lot for doing this!

Is there expected output ?
All tests suppose to pass on the latest net-next?

I'm seeing:
./fcnal-test.sh
...
SYSCTL: net.ipv4.raw_l3mdev_accept=0
TEST: ping out - ns-B IP                                                      [ OK ]
TEST: ping out, device bind - ns-B IP                                         [ OK ]
TEST: ping out, address bind - ns-B IP                                        [FAIL]
TEST: ping out - ns-B loopback IP                                             [ OK ]
TEST: ping out, device bind - ns-B loopback IP                                [ OK ]
TEST: ping out, address bind - ns-B loopback IP                               [FAIL]
TEST: ping in - ns-A IP                                                       [ OK ]
TEST: ping in - ns-A loopback IP                                              [ OK ]
TEST: ping local - ns-A IP                                                    [ OK ]
TEST: ping local - ns-A loopback IP                                           [ OK ]
TEST: ping local - loopback                                                   [ OK ]
TEST: ping local, device bind - ns-A IP                                       [ OK ]
TEST: ping local, device bind - ns-A loopback IP                              [FAIL]
TEST: ping local, device bind - loopback                                      [FAIL]

with -v I see:
COMMAND: ip netns exec ns-A ping -c1 -w1 -I 172.16.2.1 172.16.1.2
ping: unknown iface 172.16.2.1
TEST: ping out, address bind - ns-B IP                                        [FAIL]

Any tips for further debug?

Do you really need 'sleep 1' everywhere?
It makes them so slow to run...
What happens if you just remove it ? Tests will fail? Why?