netdev - Re: [v2,0/2] tools: bpftool: add net attach/detach command to attach XDP prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEKGpzgeXtFEwVXtg7B4Q=dzFUJ5KECZmCdsN=Ka1uYHTOEVpg@mail.gmail.com>
Date:   Fri, 2 Aug 2019 14:07:10 +0900
From:   "Daniel T. Lee" <danieltimlee@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [v2,0/2] tools: bpftool: add net attach/detach command to attach
 XDP prog

Thank you for letting me know.
I will add to next version of patch.

And, thank you for the detailed review. :)

On Fri, Aug 2, 2019 at 8:21 AM Jakub Kicinski
<jakub.kicinski@...ronome.com> wrote:
>
> On Thu,  1 Aug 2019 17:11:31 +0900, Daniel T. Lee wrote:
> > Currently, bpftool net only supports dumping progs attached on the
> > interface. To attach XDP prog on interface, user must use other tool
> > (eg. iproute2). By this patch, with `bpftool net attach/detach`, user
> > can attach/detach XDP prog on interface.
> >
> >     $ ./bpftool prog
> >     ...
> >     208: xdp  name xdp_prog1  tag ad822e38b629553f  gpl
> >       loaded_at 2019-07-28T18:03:11+0900  uid 0
> >     ...
> >     $ ./bpftool net attach id 208 xdpdrv enp6s0np1
> >     $ ./bpftool net
> >     xdp:
> >     enp6s0np1(5) driver id 208
> >     ...
> >     $ ./bpftool net detach xdpdrv enp6s0np1
> >     $ ./bpftool net
> >     xdp:
> >     ...
> >
> > While this patch only contains support for XDP, through `net
> > attach/detach`, bpftool can further support other prog attach types.
> >
> > XDP attach/detach tested on Mellanox ConnectX-4 and Netronome Agilio.
>
> Please provide documentation for man pages, and bash completions.