netdev - Re: [PATCH net] net: phy: fix race in genphy_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190802.181519.236187362730601447.davem@davemloft.net>
Date:   Fri, 02 Aug 2019 18:15:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        liuyonglong@...wei.com
Subject: Re: [PATCH net] net: phy: fix race in genphy_update_link

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 31 Jul 2019 23:05:10 +0200

> In phy_start_aneg() autoneg is started, and immediately after that
> link and autoneg status are read. As reported in [0] it can happen that
> at time of this read the PHY has reset the "aneg complete" bit but not
> yet the "link up" bit, what can result in a false link-up detection.
> To fix this don't report link as up if we're in aneg mode and PHY
> doesn't signal "aneg complete".
> 
> [0] https://marc.info/?t=156413509900003&r=1&w=2
> 
> Fixes: 4950c2ba49cc ("net: phy: fix autoneg mismatch case in genphy_read_status")
> Reported-by: liuyonglong <liuyonglong@...wei.com>
> Tested-by: liuyonglong <liuyonglong@...wei.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.