[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190803013031.GA76252@archlinux-threadripper>
Date: Fri, 2 Aug 2019 18:30:31 -0700
From: Nathan Chancellor <natechancellor@...il.com>
To: David Miller <davem@...emloft.net>
Cc: andrew@...n.ch, broonie@...nel.org, devel@...verdev.osuosl.org,
f.fainelli@...il.com, gregkh@...uxfoundation.org,
hkallweit1@...il.com, kernel-build-reports@...ts.linaro.org,
linux-arm-kernel@...ts.infradead.org, linux-next@...r.kernel.org,
netdev@...r.kernel.org, willy@...radead.org, lkp@...el.com,
rdunlap@...radead.org
Subject: Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning
On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote:
> From: Nathan Chancellor <natechancellor@...il.com>
> Date: Wed, 31 Jul 2019 11:50:24 -0700
>
> > arm allyesconfig warns:
> >
> > WARNING: unmet direct dependencies detected for MDIO_OCTEON
> > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y]
> > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y]
> > Selected by [y]:
> > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC &&
> > NETDEVICES [=y] || COMPILE_TEST [=y])
> >
> > and errors:
> >
> > In file included from ../drivers/net/phy/mdio-octeon.c:14:
> > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe':
> > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of
> > function 'writeq'; did you mean 'writeb'?
>
> The proper way to fix this is to include either
>
> linux/io-64-nonatomic-hi-lo.h
>
> or
>
> linux/io-64-nonatomic-lo-hi.h
>
> whichever is appropriate.
Hmmmm, is that not what I did?
Although I did not know about io-64-nonatomic-hi-lo.h. What is the
difference and which one is needed here?
There is apparently another failure when OF_MDIO is not set, I guess I
can try to look into that as well and respin into a series if
necessary.
Cheers,
Nathan
Powered by blists - more mailing lists