netdev - Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190803060528.GA89737@archlinux-threadripper>
Date:   Fri, 2 Aug 2019 23:05:28 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     David Miller <davem@...emloft.net>, andrew@...n.ch,
        broonie@...nel.org, devel@...verdev.osuosl.org,
        f.fainelli@...il.com, gregkh@...uxfoundation.org,
        hkallweit1@...il.com, kernel-build-reports@...ts.linaro.org,
        linux-arm-kernel@...ts.infradead.org, linux-next@...r.kernel.org,
        netdev@...r.kernel.org, lkp@...el.com, rdunlap@...radead.org
Subject: Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning

On Fri, Aug 02, 2019 at 06:39:52PM -0700, Matthew Wilcox wrote:
> On Fri, Aug 02, 2019 at 06:30:31PM -0700, Nathan Chancellor wrote:
> > On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote:
> > > The proper way to fix this is to include either
> > > 
> > > 	linux/io-64-nonatomic-hi-lo.h
> > > 
> > > or
> > > 
> > > 	linux/io-64-nonatomic-lo-hi.h
> > > 
> > > whichever is appropriate.
> > 
> > Hmmmm, is that not what I did?
> > 
> > Although I did not know about io-64-nonatomic-hi-lo.h. What is the
> > difference and which one is needed here?
> 
> Whether you write the high or low 32 bits first.  For this, it doesn't
> matter, since the compiled driver will never be run on real hardware.

That's what I figured. I have only seen lo-hi used personally, which is
what I went with here. Thanks for the confirmation!

> 
> > There is apparently another failure when OF_MDIO is not set, I guess I
> > can try to look into that as well and respin into a series if
> > necessary.
> 
> Thanks for taking care of that!