netdev - Re: [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190803164015.eiy4hanb27qyrjzz@salvia>
Date:   Sat, 3 Aug 2019 18:40:15 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Julian Anastasov <ja@....bg>
Cc:     hujunwei <hujunwei4@...wei.com>, wensong@...ux-vs.org,
        horms@...ge.net.au, kadlec@...ckhole.kfki.hu,
        Florian Westphal <fw@...len.de>, davem@...emloft.net,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, Mingfangsen <mingfangsen@...wei.com>,
        wangxiaogang3@...wei.com, xuhanbing@...wei.com
Subject: Re: [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl

On Wed, Jul 31, 2019 at 08:53:47PM +0300, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Thu, 1 Aug 2019, hujunwei wrote:
> 
> > From: Junwei Hu <hujunwei4@...wei.com>
> > 
> > The ipvs module parse the user buffer and save it to sysctl,
> > then check if the value is valid. invalid value occurs
> > over a period of time.
> > Here, I add a variable, struct ctl_table tmp, used to read
> > the value from the user buffer, and save only when it is valid.
> > I delete proc_do_sync_mode and use extra1/2 in table for the
> > proc_dointvec_minmax call.
> > 
> > Fixes: f73181c8288f ("ipvs: add support for sync threads")
> > Signed-off-by: Junwei Hu <hujunwei4@...wei.com>
> > Acked-by: Julian Anastasov <ja@....bg>
> 
> 	Yep, Acked-by: Julian Anastasov <ja@....bg>

Applied, thanks.