netdev - Re: [PATCH] net: sched: use temporary variable for actions indexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190805.110001.1510283366849683723.davem@davemloft.net>
Date:   Mon, 05 Aug 2019 11:00:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dmitrolin@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...nulli.us, jhs@...atatu.com,
        xiyou.wangcong@...il.com, vladbu@...lanox.com
Subject: Re: [PATCH] net: sched: use temporary variable for actions indexes

From: dmitrolin@...lanox.com
Date: Thu,  1 Aug 2019 13:02:51 +0000

> From: Dmytro Linkin <dmitrolin@...lanox.com>
> 
> Currently init call of all actions (except ipt) init their 'parm'
> structure as a direct pointer to nla data in skb. This leads to race
> condition when some of the filter actions were initialized successfully
> (and were assigned with idr action index that was written directly
> into nla data), but then were deleted and retried (due to following
> action module missing or classifier-initiated retry), in which case
> action init code tries to insert action to idr with index that was
> assigned on previous iteration. During retry the index can be reused
> by another action that was inserted concurrently, which causes
> unintended action sharing between filters.
> To fix described race condition, save action idr index to temporary
> stack-allocated variable instead on nla data.
> 
> Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
> Signed-off-by: Dmytro Linkin <dmitrolin@...lanox.com>
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Applied and queued up for -stable, thanks.