lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 05 Aug 2019 13:15:52 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jakub.kicinski@...ronome.com Cc: netdev@...r.kernel.org, oss-drivers@...ronome.com, edumazet@...gle.com, davejwatson@...com, borisp@...lanox.com, aviadye@...lanox.com, john.fastabend@...il.com, daniel@...earbox.net Subject: Re: [PATCH net 1/2] net/tls: partially revert fix transition through disconnect with close From: Jakub Kicinski <jakub.kicinski@...ronome.com> Date: Thu, 1 Aug 2019 14:36:01 -0700 > Looks like we were slightly overzealous with the shutdown() > cleanup. Even though the sock->sk_state can reach CLOSED again, > socket->state will not got back to SS_UNCONNECTED once > connections is ESTABLISHED. Meaning we will see EISCONN if > we try to reconnect, and EINVAL if we try to listen. > > Only listen sockets can be shutdown() and reused, but since > ESTABLISHED sockets can never be re-connected() or used for > listen() we don't need to try to clean up the ULP state early. > > Fixes: 32857cf57f92 ("net/tls: fix transition through disconnect with close") > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com> Applied and queued up for -stable.
Powered by blists - more mailing lists