netdev - Re: [PATCH net] net/smc: avoid fallback in case of non-blocking connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 05 Aug 2019 13:25:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kgraul@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        gor@...ux.ibm.com, heiko.carstens@...ibm.com, raspl@...ux.ibm.com,
        ubraun@...ux.ibm.com
Subject: Re: [PATCH net] net/smc: avoid fallback in case of non-blocking
 connect

From: Karsten Graul <kgraul@...ux.ibm.com>
Date: Fri,  2 Aug 2019 10:47:50 +0200

> From: Ursula Braun <ubraun@...ux.ibm.com>
> 
> FASTOPEN is not possible with SMC. sendmsg() with msg_flag MSG_FASTOPEN
> triggers a fallback to TCP if the socket is in state SMC_INIT.
> But if a nonblocking connect is already started, fallback to TCP
> is no longer possible, even though the socket may still be in state
> SMC_INIT.
> And if a nonblocking connect is already started, a listen() call
> does not make sense.
> 
> Reported-by: syzbot+bd8cc73d665590a1fcad@...kaller.appspotmail.com
> Fixes: 50717a37db032 ("net/smc: nonblocking connect rework")
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@...ux.ibm.com>

Applied and queued up for -stable.